php - SELECT Query, WHERE selects all when "" is empty -


the aim

hi, i'm trying shorten code building query dynamically based on $_get. current have every possible if statement relevant select query. create dynamic system feature updates.

current progress

//set filter based on url         if ($_get[game] != "") { $gamefilter = $_get[game]; } else { $gamefilter = ''; }         if ($_get[region] != "") { $regionfilter = $_get[region]; } else { $regionfilter = ''; }         if ($_get[console] != "") { $consolefilter = $_get[console]; } else { $consolefilter = ''; }      $result = get_matchfinder($gamefilter, $regionfilter, $consolefilter);

//the function

function get_matchfinder($gamefilter, $regionfilter, $consolefilter) {         //set varibles         $database = 'matchfinder';         $order = 'desc';         $limit = '20';      //query function     $connection = connection();     $sql = 'select *  '. $database .' game = "'.$gamefilter.'" , region = "'.$regionfilter.'" , console = "'.$consolefilter.'" order id '. $order .' limit '. $limit .'';     $response = mysqli_query($connection, $sql);         //return     return $response; }

problem currenly works when of filters active if 1 of them isn't whole query fails, know thats because try select matching ''.

so questions how make search when filters not set?

you should build query parts depending on length of filter:

$sql = '     select * '.$database.' ';  $filters = array(); if (strlen($gamefilter) > 0) {     $filters[] = 'game = "'.mysqli_escape_string($connection, $gamefilter).'"'; } if (strlen($regionfilter) > 0) {     $filters[] = 'region = "'.mysqli_escape_string($connection, $regionfilter).'"'; } if (strlen($consolefilter ) > 0) {     $filters[] = 'console= "'.mysqli_escape_string($connection, $consolefilter).'"'; }  if (count($filters) > 0) {     $sql .= ' '.implode(' , ', $filters); }  if (strlen($oder) > 0) {     $sql .= ' order id '.$order; } if ($limit > 0) {     $sql .= ' limit '.$limit; }  $response = mysqli_query($connection, $sql);

what you're doing there building array of conditions, based on length of condition. if condition's input empty string, isn't added array. @ end, if there filters, use implode bind conditions string. way implode works, if there's 1 condition, glue string isn't used.

it bears mentioning exposing sql injection. above code shows use of mysqli_escape_string escape input, should in parameterized queries take full precaution: http://php.net/manual/en/mysqli.quickstart.prepared-statements.php -- above sample different if used paraterized queries, more safe.

documentation


-

Comments

Post a Comment

Popular posts from this blog

PySide and Qt Properties: Connecting signals from Python to QML -

i trying run simple pyside appliccation design made in qml. call function in qml python in separated thread. i have following qml view: import qt 4.7 rectangle { visible: true width: 100; height: 100 color: "lightgrey" text { id: datestr objectname: "datestr" x: 10 y: 10 text: "init text" font.pixelsize: 12 function updatedata(text) { datestr.text = qstr(text) console.log("you said: " + text) } } } here application: some imports.... #!/usr/bin/python import sys import time pyside import qtdeclarative, qtcore pyside.qtgui import qapplication pyside.qtdeclarative import qdeclarativeview the qthread worker.... #worker thread class worker(qtcore.qthread): updateprogress = qtcore.signal(int) def __init__(self, child): qtcore.qthread.__init__(self) self.child = child def run(self):
Read more

c# - DevExpress.Wpf.Grid.InfiniteGridSizeException was unhandled -

Image
when using devexpress, see error: devexpress.wpf.grid.infinitegridsizeexception unhandled message="by default, infinite grid height not allowed since grid rows rendered , hence grid work slowly. fix issue, should place grid container give finite height grid, or should manually specify grid's height or maxheight. note can avoid exception setting gridcontrol.allowinfinitegridsize static property true, in case grid run slowly." the problem dxgrid has infinite height. to fix, set height non-infinite. snoop absolutely invaluable this: if "height" xaml element infinite (i.e. 0 or nan ), can set using one of following: option 1: height="{binding path=actualheight, relativesource={relativesource mode=findancestor, ancestortype=uielement}}" option 2: verticalalignment="stretch" option 3: height="auto" hint: use verticalalignment="stretch" if child of grid <rowdefinition height=
Read more

scala - 'wrong top statement declaration' when using slick in IntelliJ -

Image
i'm porting project scala 2.9 2.10, therefore have use slick instead of scalaquery. i'm using slick 2.1.0 since supports ms access. according this tutorial , upgrade guide changed robs object class , added val robs : why error message wrong top statement declaration , how rid of it? edit: i'm new scala... according this question seems can't put val outside of methods or classes, right? code above directly in packge. right approach slick then? should move code in class or trait? according this changed val robs = tablequery[robs] to object robs extends tablequery(new robs(_)) {} . no warnings or errors anymore. :)
Read more