oracle - JAVA SQL command not properly ended -


i have code:

buy.addactionlistener(new actionlistener() {     @override     public void actionperformed(actionevent actionevent)     {         int r;         r = table.getselectedrow();         string num = (string) table.getvalueat(r, 0);//numele jucariei         //string cop = (string) table.getvalueat(r, 3);//nr de bucati          try         {             pq = stmt.executequery("select *" + "from buyid_view");             xv = stmt.executequery("select toyid, copies " + "from alldatas_view" + "where toyname ='"+num+"'");             int buyid = pq.getint("buyid");             int toyid = xv.getint("toyid");             int copies = xv.getint("copies");             copies = copies-1;             callablestatement cstmt = con.preparecall("insert buy (buyid, toyid)" + "values (?,?)");             cstmt.setint("buyid", buyid);             cstmt.setint("toyid", toyid);             resultset rs = cstmt.executequery();             joptionpane.showmessagedialog(null, "you brought toy.");              for(int = 0; < table.getrowcount(); i++)                 for(int j = 0; j < table.getcolumncount(); j++)                     table.setvalueat("", i, j);              try             {                 rs = stmt.executequery("update toys set copies "+ copies +"where toyid= '"+toyid+"'");             }             catch (sqlexception e)             {                 joptionpane.showmessagedialog(null, e.getmessage());             }              int = 0;              try             {                 rs = stmt.executequery("select *"+                         "from availablebooks_view");             }             catch (sqlexception e)             {                 e.printstacktrace();             }                         {                 try {                     if(rs.next())                     {                         table.setvalueat(rs.getstring(1), i, 0);                         table.setvalueat(rs.getstring(2), i, 1);                         table.setvalueat(rs.getstring(3), i, 2);                         i++;                         while(rs.next())                         {                             table.setvalueat(rs.getstring(1), i, 0);                             table.setvalueat(rs.getstring(2), i, 1);                             table.setvalueat(rs.getstring(3), i, 2);                             i++;                         }                     }                 } catch (sqlexception e) {                     joptionpane.showmessagedialog(null, e.getmessage());                 }             }         }         catch (sqlexception e)         {             if(e.getmessage().contains("you have pay!"))                 warning(frame, "you didn't pay products");             else                 warning(frame, e.getmessage());         }     } });

when compile program don't have error when run , click on buy button gives me error saying "ora-00933: sql command not ended".

when building sql statements strings must ensure there spaces spaces needed. 

rs = stmt.executequery("select *"+      "from availablebooks_view");

the statement sending 

select *from availablebooks_view

which invalid syntax. have problem in several places in code.

however, have larger issue results building sql statements piecemeal. leaves open sql injection , should rewrite code use prepared statements , parameters instead.


-

Comments

Post a Comment

Popular posts from this blog

PySide and Qt Properties: Connecting signals from Python to QML -

i trying run simple pyside appliccation design made in qml. call function in qml python in separated thread. i have following qml view: import qt 4.7 rectangle { visible: true width: 100; height: 100 color: "lightgrey" text { id: datestr objectname: "datestr" x: 10 y: 10 text: "init text" font.pixelsize: 12 function updatedata(text) { datestr.text = qstr(text) console.log("you said: " + text) } } } here application: some imports.... #!/usr/bin/python import sys import time pyside import qtdeclarative, qtcore pyside.qtgui import qapplication pyside.qtdeclarative import qdeclarativeview the qthread worker.... #worker thread class worker(qtcore.qthread): updateprogress = qtcore.signal(int) def __init__(self, child): qtcore.qthread.__init__(self) self.child = child def run(self):
Read more

c# - DevExpress.Wpf.Grid.InfiniteGridSizeException was unhandled -

Image
when using devexpress, see error: devexpress.wpf.grid.infinitegridsizeexception unhandled message="by default, infinite grid height not allowed since grid rows rendered , hence grid work slowly. fix issue, should place grid container give finite height grid, or should manually specify grid's height or maxheight. note can avoid exception setting gridcontrol.allowinfinitegridsize static property true, in case grid run slowly." the problem dxgrid has infinite height. to fix, set height non-infinite. snoop absolutely invaluable this: if "height" xaml element infinite (i.e. 0 or nan ), can set using one of following: option 1: height="{binding path=actualheight, relativesource={relativesource mode=findancestor, ancestortype=uielement}}" option 2: verticalalignment="stretch" option 3: height="auto" hint: use verticalalignment="stretch" if child of grid <rowdefinition height=
Read more

scala - 'wrong top statement declaration' when using slick in IntelliJ -

Image
i'm porting project scala 2.9 2.10, therefore have use slick instead of scalaquery. i'm using slick 2.1.0 since supports ms access. according this tutorial , upgrade guide changed robs object class , added val robs : why error message wrong top statement declaration , how rid of it? edit: i'm new scala... according this question seems can't put val outside of methods or classes, right? code above directly in packge. right approach slick then? should move code in class or trait? according this changed val robs = tablequery[robs] to object robs extends tablequery(new robs(_)) {} . no warnings or errors anymore. :)
Read more